[crac] RFR: Add CRaC-specific tests to GHA [v7]

Radim Vansa duke at openjdk.org
Fri Mar 24 10:31:56 UTC 2023


On Fri, 24 Mar 2023 10:20:41 GMT, Radim Vansa <duke at openjdk.org> wrote:

>> test/jdk/jdk/crac/SecureRandom/ReseedTest.java line 75:
>> 
>>> 73: 
>>> 74:         System.out.println(sr.nextInt());
>>> 75:         System.exit(0);
>> 
>> This change will also help when something is wrong with the restore, the previous version might confuse that situation with legitimate return with non-zero error. 
>> 
>> On the second thought, could you extract this into a separate PR?
>
> If you promise me that you'll integrate right away, I can :)

Here it goes: https://github.com/openjdk/crac/pull/55
I've reverted the commit in this PR

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/48#discussion_r1147390843


More information about the crac-dev mailing list