[crac] RFR: Ensure all notifications finish even if only daemon threads remain [v2]

Radim Vansa duke at openjdk.org
Thu May 4 20:32:49 UTC 2023


On Thu, 4 May 2023 17:17:46 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> If as a result of beforeCheckpoint() no more non-daemon threads remain, it's possible that VM exits prematurely, before one of afterRestore() get a chance to create another non-daemon thread that will keep VM alive. Triggering checkpoint via jcmd (so checkpointRestore() method is executed on daemon attach-listener thread), increases probability to step in the problem.
>> 
>> The change ensures all notifications are done while there is at least one non-daemon thread. The notification methods are still called from the original thread.
>
> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test update

If not using a Resource, at least refactor that into a standalone (stateful) component, which may be called directly. The way it's written here mixes in some implementation details into a higher-level flow.

-------------

PR Comment: https://git.openjdk.org/crac/pull/62#issuecomment-1535371199


More information about the crac-dev mailing list