[crac] RFR: Ensure all notifications finish even if only daemon threads remain [v2]

Radim Vansa duke at openjdk.org
Wed May 10 06:27:40 UTC 2023


On Thu, 4 May 2023 17:23:28 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test update
>
> Thank you for review.
> 
>> Rather than clobbering the 'general' C/R code with a fix for one issue, there is an interface perfectly suited to host this - a Resource.
> 
> Having Resource abstraction does not mean that is necessary to use. Resources are suited for objects which may or may not exist and still need to receive notifications. Here we have no problems with doing something directly. So we don't need to rely on some implicit ordering, nor don't need to change Contextes structure.

@AntonKozlov I've addressed the interrupts and moved KeepAlive to separate impl class in https://github.com/rvansa/crac/tree/daemon-after-restore - could you ff-merge into your branch to avoid opening another PR?

-------------

PR Comment: https://git.openjdk.org/crac/pull/62#issuecomment-1541421555


More information about the crac-dev mailing list