[crac] RFR: Improved open file descriptors tracking [v9]

[Radim Vansa]

On Tue, 2 May 2023 16:50:11 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Provide more information for file descriptors
>
> src/java.base/share/classes/java/io/FileDescriptor.java line 400:
> 
>> 398:                 } else {
>> 399:                     info = (path != null ? path : "unknown path") + " (" + (type != null ? type : "unknown") + ")";
>> 400:                 }
> 
> This have too many socket-related details, also a number of java/native transitions that will be unavoidable if we adopt the proposed interface.

I am thinking about this also in a context of `newfd-policies`, where we have to record not only the type & path but also things like current offset etc.
Since this is used only in error handling, I wouldn't mind about the native transitions (or performance in general) too much. If you want, I could create a POJO to cross the native border only once. However this goes a bit against the principle that we want to handle as much as we can in Java rather than native code. That's also the reason why I opted for the formatting in Java even though it might be just as simple to do it in the native.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/43#discussion_r1188785933