[crac] RFR: Improved open file descriptors tracking [v9]

[Radim Vansa]

On Tue, 2 May 2023 17:00:11 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Provide more information for file descriptors
>
> src/java.base/unix/native/libnet/SocketImpl.c line 115:
> 
>> 113:            return NULL;
>> 114:         }
>> 115:     }
> 
> No need for `} else {` here and everywhere else since the previous block has anyway terminated the function.
> 
> This will make the code more streamlined.
> 
> Suggestion:
> 
> }
> 
> localAddr = create_isa(env, isa_class, isa_ctor, &local);
> if (localAddr == NULL) {
>     JNU_ThrowOutOfMemoryError(env, "java.net.InetSocketAddres");
>     return NULL;
> }

The code was supposed to mirror closer the remote part where we can't do that, but OK.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/43#discussion_r1188790339