[crac] RFR: RFC: -XX:CPUFeatures=0xnumber for CPU migration [v14]

Jan Kratochvil duke at openjdk.org
Tue May 16 13:21:24 UTC 2023


On Thu, 4 May 2023 17:56:28 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   -altstack
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 717:
> 
>> 715:         if ((excessive_CPU & CPU_SSE3) ||
>> 716:             (excessive_GLIBC & (GLIBC_CMPXCHG16 | GLIBC_LAHFSAHF))) {
>> 717:           assert(!(excessive_CPU & CPU_SSE4_2), "(_features & CPU_SSE4_2) cannot happen");
> 
> Failed assert prints the failed condition, no need to repeat in the message.

`_features` and `excessive_CPU` are two distinct variables. I have tried to rephrase the message:

assert(!(excessive_CPU & CPU_SSE4_2), "CPU_SSE4_2 in both _features and excessive_CPU cannot happen");

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/41#discussion_r1195149131


More information about the crac-dev mailing list