[crac] RFR: RFC: -XX:CPUFeatures=0xnumber for CPU migration [v14]

[Jan Kratochvil]

On Thu, 4 May 2023 17:39:25 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   -altstack
>
> src/hotspot/share/runtime/stubCodeGenerator.cpp line 62:
> 
>> 60: void StubCodeDesc::thaw() {
>> 61:   assert(_frozen, "repeated thaw operation");
>> 62:   _frozen = false;
> 
> Is it still necessary? I've tried to comment this line out, and checkpoint-restore succeded for me.

I get during restore:

#  Internal Error (../../src/hotspot/share/runtime/stubCodeGenerator.hpp:72), pid=12265, tid=12273
#  assert(!_frozen) failed: no modifications allowed

Did you really use a `*debug` build (and not `release` build)? The crash above has been generated on `slowdebug`.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/41#discussion_r1197863674