[crac] RFR: Introduce per-Priority Context with different policies

[Radim Vansa]

On Thu, 18 May 2023 16:21:07 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> test/jdk/jdk/crac/ContextOrderTest.java line 106:
>> 
>>> 104: 
>>> 105:         // blocks register into the same OrderedContext
>>> 106:         Context<Resource> context = new BlockingOrderedContext<>();
>> 
>> Why does this create a children context rather than using global one directly?
>
> Global Context was changed to non-blocking OrderedContext as stated in the PR description, but the test needs BlockingOrderedContext.

Yes, but it does not explain much about the **reason** but "... as that may have a huge impact on users". I don't think there's much concern about backwards compatibility at this point; it's more important to have the best UX even in case that users do an error.

If you want to conserve certain behaviour, write a test that will validate what happens when you attempt to register into global context in one of those notifications.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/74#discussion_r1198615862