[crac] RFR: Introduce per-Priority Context with different policies

Anton Kozlov akozlov at openjdk.org
Wed May 24 12:53:28 UTC 2023


On Fri, 19 May 2023 07:01:01 GMT, Radim Vansa <duke at openjdk.org> wrote:

>> Global Context was changed to non-blocking OrderedContext as stated in the PR description, but the test needs BlockingOrderedContext.
>
> Yes, but it does not explain much about the **reason** but "... as that may have a huge impact on users". I don't think there's much concern about backwards compatibility at this point; it's more important to have the best UX even in case that users do an error.
> 
> If you want to conserve certain behaviour, write a test that will validate what happens when you attempt to register into global context in one of those notifications.

Apparently you mean why the global context implementation has been changed, not why the test has to use an explicit implementation.

Honestly I did not realize the global context properties were changed in #60, so I just want to revert that for a while. This was rather big change. And that deserved a separate line in the javadoc, which is btw the specification, not the tests (although they are definetely useful). I lean toward using BlockingContext, but want to think a bit more about that, with the spec change.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/74#discussion_r1204074255


More information about the crac-dev mailing list