[crac] RFR: Compile all the INCLUDE_LD_SO_LIST_DIAGNOSTICS code unconditionally [v4]

[Jan Kratochvil]

On Tue, 31 Oct 2023 07:00:09 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

> While I like the certainty that the code is always compilable, I wonder if handling optional features like this (using macros in conditions) is a pattern that is used elsewhere in the JDK?

I haven't found such case. I expect to leave such decisions up to OpenJDK reviewers during CRaC merge request.

OTOH to make things easier - the whole `INCLUDE_LD_SO_LIST_DIAGNOSTICS` code should be probably removed. The support for `INCLUDE_LD_SO_LIST_DIAGNOSTICS` will probably never be used as it was added to glibc only few months before the (better) `INCLUDE_CPU_FEATURE_ACTIVE` support. Before doing such removal for real one should check whether any major/supported Linux distribution has been released with such glibc version supporting only `INCLUDE_LD_SO_LIST_DIAGNOSTICS` without `INCLUDE_CPU_FEATURE_ACTIVE`. I unfortunately did not check what was when implemented in glibc while writing the `INCLUDE_LD_SO_LIST_DIAGNOSTICS` code.

-------------

PR Comment: https://git.openjdk.org/crac/pull/136#issuecomment-1798672875