[crac] RFR: Compile all the INCLUDE_LD_SO_LIST_DIAGNOSTICS code unconditionally [v4]

Tue Nov 7 15:08:10 UTC 2023

On Tue, 31 Oct 2023 10:23:14 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> Make INCLUDE_LD_SO_LIST_DIAGNOSTICS an `if` conditional instead of a `#if` one.
>> Fix compilation failures.
>
> Jan Kratochvil has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix compilation on non-Linux OSes
>  - Fix more compilation problems

It's in our interest to provoke as few discussions as possible, to get CRaC merged without extra delay. So, the code style is questionable and there's actually very little chance it will be useful, do you still consider this worth merging? Or would you prefer to remove it altogether instead? (Could be done in this very PR)

-------------

PR Comment: https://git.openjdk.org/crac/pull/136#issuecomment-1798794794