[crac] RFR: Handle C/R in BasicImageReader (via reflection)

[Radim Vansa]

On Wed, 15 Nov 2023 18:31:45 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Fixes checkpoint failure due to open FD to modules on x86 (the Java code behaves differently on 32bit and 64bt).
>
> src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java line 109:
> 
>> 107:             channel = null;
>> 108:         } else {
>> 109:             channel = openFileChannel();
> 
> Could you avoid this refactoring to simplify future merges?

Do you mean to just copy-paste the `openFileChannel()` code? Do we rather want any change in that code go unnoticed?

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/124#discussion_r1395441271