[crac] RFR: Handle C/R in BasicImageReader (via reflection)

[Anton Kozlov]

On Thu, 16 Nov 2023 09:56:37 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java line 109:
>> 
>>> 107:             channel = null;
>>> 108:         } else {
>>> 109:             channel = openFileChannel();
>> 
>> Could you avoid this refactoring to simplify future merges?
>
> Do you mean to just copy-paste the `openFileChannel()` code? Do we rather want any change in that code go unnoticed?

Oh! I see, you did refactoring to call openFileChannel() from registerIfCRaCPresent(). OK, that makes sense.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/124#discussion_r1395547760