[crac] RFR: CRaC: Fix fds opened for logging [v2]

Jan Kratochvil jkratochvil at openjdk.org
Mon Oct 2 14:56:04 UTC 2023

On Tue, 26 Sep 2023 11:40:45 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>>  - AsyncLogWriter: add stop() and resume()
>>  - Merge branch 'crac' into crac-logfd
>>  - b229ea41: <no commit message found>
>>  - 8f161825: <no commit message found>
>>  - d8a454cb: <no commit message found>
>>  - Merge branch 'crac' into crac-logfd
>>  - +testcase
>>  - CRaC: Fix fds opened for logging
> src/hotspot/share/runtime/crac.cpp line 431:
>> 429:   Universe::heap()->finish_collection();
>> 430: 
>> 431:   AsyncLogWriter::instance()->flush();
> As a non-java thread, AsyncLogWriter does not participate in the safepoint protocol. What happens if another non-java thread enqueues a message to be written while the output is closed?

OK, I have to improve it, thanks.


PR Review Comment: https://git.openjdk.org/crac/pull/113#discussion_r1337256728

More information about the crac-dev mailing list