[crac] RFR: CRaC: Fix fds opened for logging [v2]

Jan Kratochvil jkratochvil at openjdk.org
Mon Oct 2 14:56:05 UTC 2023

On Tue, 26 Sep 2023 13:56:50 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> src/hotspot/share/runtime/crac.cpp line 431:
>>> 429:   Universe::heap()->finish_collection();
>>> 430: 
>>> 431:   AsyncLogWriter::instance()->flush();
>> As a non-java thread, AsyncLogWriter does not participate in the safepoint protocol. What happens if another non-java thread enqueues a message to be written while the output is closed?
> OK, I have to improve it, thanks.

I hope the stop() and resume() do fix it. But there is no testcase for that, do you want it?


PR Review Comment: https://git.openjdk.org/crac/pull/113#discussion_r1342793215

More information about the crac-dev mailing list