[crac] RFR: Fix compilation with clang

Radim Vansa rvansa at openjdk.org
Fri Oct 6 06:57:35 UTC 2023


On Thu, 5 Oct 2023 15:38:55 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> ../../src/hotspot/os/linux/crac_linux.cpp:192:13: error: using the result of an assignment as a condition without parentheses [-Werror,-Wparentheses]
>   while (dp = readdir(dir)) {
>          ~~~^~~~~~~~~~~~~~
> ../../src/hotspot/os/linux/crac_linux.cpp:192:13: note: place parentheses around the assignment to silence this warning
>   while (dp = readdir(dir)) {
>             ^
>          (                )
> ../../src/hotspot/os/linux/crac_linux.cpp:192:13: note: use '==' to turn this assignment into an equality comparison
>   while (dp = readdir(dir)) {
>             ^
>             ==
> ../../src/hotspot/os/linux/crac_linux.cpp:402:13: error: using the result of an assignment as a condition without parentheses [-Werror,-Wparentheses]
>   while (dp = readdir(dir)) {
>          ~~~^~~~~~~~~~~~~~
> ../../src/hotspot/os/linux/crac_linux.cpp:402:13: note: place parentheses around the assignment to silence this warning
>   while (dp = readdir(dir)) {
>             ^
>          (                )
> ../../src/hotspot/os/linux/crac_linux.cpp:402:13: note: use '==' to turn this assignment into an equality comparison
>   while (dp = readdir(dir)) {
>             ^
>             ==
> 2 errors generated.

Marked as reviewed by rvansa (Committer).

-------------

PR Review: https://git.openjdk.org/crac/pull/122#pullrequestreview-1661222184


More information about the crac-dev mailing list