[crac] Integrated: Fix compilation with clang

Jan Kratochvil jkratochvil at openjdk.org
Fri Oct 6 11:15:28 UTC 2023


On Thu, 5 Oct 2023 15:38:55 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> ../../src/hotspot/os/linux/crac_linux.cpp:192:13: error: using the result of an assignment as a condition without parentheses [-Werror,-Wparentheses]
>   while (dp = readdir(dir)) {
>          ~~~^~~~~~~~~~~~~~
> ../../src/hotspot/os/linux/crac_linux.cpp:192:13: note: place parentheses around the assignment to silence this warning
>   while (dp = readdir(dir)) {
>             ^
>          (                )
> ../../src/hotspot/os/linux/crac_linux.cpp:192:13: note: use '==' to turn this assignment into an equality comparison
>   while (dp = readdir(dir)) {
>             ^
>             ==
> ../../src/hotspot/os/linux/crac_linux.cpp:402:13: error: using the result of an assignment as a condition without parentheses [-Werror,-Wparentheses]
>   while (dp = readdir(dir)) {
>          ~~~^~~~~~~~~~~~~~
> ../../src/hotspot/os/linux/crac_linux.cpp:402:13: note: place parentheses around the assignment to silence this warning
>   while (dp = readdir(dir)) {
>             ^
>          (                )
> ../../src/hotspot/os/linux/crac_linux.cpp:402:13: note: use '==' to turn this assignment into an equality comparison
>   while (dp = readdir(dir)) {
>             ^
>             ==
> 2 errors generated.

This pull request has now been integrated.

Changeset: b6d39f11
Author:    Jan Kratochvil <jkratochvil at openjdk.org>
Committer: Radim Vansa <rvansa at openjdk.org>
URL:       https://git.openjdk.org/crac/commit/b6d39f11bc216c097dcc255a37e859b6c8d01144
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

Fix compilation with clang

Reviewed-by: rvansa

-------------

PR: https://git.openjdk.org/crac/pull/122


More information about the crac-dev mailing list