[crac] RFR: Reset JVM start time and up time on restore (CRaCResetStartTime) [v2]
Roman Marchenko
rmarchenko at openjdk.org
Wed Oct 18 08:33:06 UTC 2023
On Wed, 18 Oct 2023 08:24:49 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:
>> src/hotspot/os/linux/crac_linux.cpp line 468:
>>
>>> 466:
>>> 467: void crac::initialize_time_counters() {
>>> 468: os::Posix::init();
>>
>> The initialization updates some condition variable attributes; have you checked if there's any chance that another thread could observe an inconsistent state while this is updated?
>
> You're right, I missed it.
Done
>> test/jdk/jdk/crac/ResetStartTimeTest.java line 44:
>>
>>> 42: * @run driver/timeout=60 jdk.test.lib.crac.CracTest true
>>> 43: */
>>> 44: public class SimpleTest implements CracTest {
>>
>> Could you please name the test `ResetStartTimeTest` to match the filename?
>
> Ye olde copy-n-paste :)
> Thanks!
Done
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/130#discussion_r1363475223
PR Review Comment: https://git.openjdk.org/crac/pull/130#discussion_r1363474387
More information about the crac-dev
mailing list