[crac] RFR: Reset JVM start time and up time on restore (CRaCResetStartTime) [v2]
Roman Marchenko
rmarchenko at openjdk.org
Wed Oct 18 08:33:08 UTC 2023
On Tue, 17 Oct 2023 11:37:11 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixing review comments
>
> test/jdk/jdk/crac/ResetStartTimeTest.java line 40:
>
>> 38: * @library /test/lib
>> 39: * @build SimpleTest
>> 40: * @requires (os.family == "linux")
>
> I think that if you use simengine the test is applicable to other platforms as well.
Done
> test/jdk/jdk/crac/ResetStartTimeTest.java line 75:
>
>> 73: assertLessThan(uptime1, WAIT_TIMEOUT);
>> 74: } else {
>> 75: assertLessThan(uptime0, uptime1);
>
> If the C/R is really quick this should be <=
Done
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/130#discussion_r1363474783
PR Review Comment: https://git.openjdk.org/crac/pull/130#discussion_r1363474550
More information about the crac-dev
mailing list