[crac] RFR: Reset JVM start time and up time on restore (CRaCResetStartTime) [v5]

Anton Kozlov akozlov at openjdk.org
Thu Oct 26 19:34:09 UTC 2023


On Thu, 19 Oct 2023 07:25:12 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> This change adds an opportunity reset both JVM's start time and uptime on restoring.
>> 
>> Resetting time may be performed with the new flag "-XX:+CRaCResetStartTime".
>> 
>> The flag is 'false' by default.
>
> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing win32 build

src/hotspot/share/runtime/globals.hpp line 2001:

> 1999:   product(bool, CRaCResetStartTime, false, RESTORE_SETTABLE,                    \
> 2000:       "Reset JVM's start time and uptime on restore")                     \
> 2001:                                                                             \

Sorry for being late. Since we're evaluating providing the restore time via getUptime(), the option should be true by default, and be diagnostic.

Nit: the end of lines are not aligned.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/130#discussion_r1373722320


More information about the crac-dev mailing list