[crac] RFR: Reset JVM start time and up time on restore (CRaCResetStartTime) [v5]

Roman Marchenko rmarchenko at openjdk.org
Thu Oct 26 19:41:13 UTC 2023


On Thu, 26 Oct 2023 19:31:15 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing win32 build
>
> src/hotspot/share/runtime/globals.hpp line 2001:
> 
>> 1999:   product(bool, CRaCResetStartTime, false, RESTORE_SETTABLE,                    \
>> 2000:       "Reset JVM's start time and uptime on restore")                     \
>> 2001:                                                                             \
> 
> Sorry for being late. Since we're evaluating providing the restore time via getUptime(), the option should be true by default, and be diagnostic.
> 
> Nit: the end of lines are not aligned.

Ok, I will change it in a new PR

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/130#discussion_r1373729413


More information about the crac-dev mailing list