[crac] RFR: Changing CRaCResetStartTime flag defaults [v2]

Radim Vansa rvansa at openjdk.org
Tue Oct 31 07:14:57 UTC 2023


On Fri, 27 Oct 2023 12:07:34 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> By the request in this comment https://github.com/openjdk/crac/pull/130/files#r1373722320
>
> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Forgot unlocking diag options

@wkia Sorry to chime in rather late, but now it seems that this flag can be set only before checkpoint; why is that? Is there an issue in making this both diagnostic and restore-settable? (I guess that `UnlockDiagnosticOptions` might need to become restore-settable, too, but I don't see an issue with that)

-------------

PR Comment: https://git.openjdk.org/crac/pull/135#issuecomment-1786589857


More information about the crac-dev mailing list