[crac] RFR: Changing CRaCResetStartTime flag defaults [v2]

Roman Marchenko rmarchenko at openjdk.org
Tue Oct 31 08:44:00 UTC 2023

On Tue, 31 Oct 2023 07:12:07 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>>   Forgot unlocking diag options
> @wkia Sorry to chime in rather late, but now it seems that this flag can be set only before checkpoint; why is that? Is there an issue in making this both diagnostic and restore-settable? (I guess that `UnlockDiagnosticOptions` might need to become restore-settable, too, but I don't see an issue with that)

@rvansa You're right, thanks. 
Need to be reviewed by @AntonKozlov also.  Should we change `UnlockDiagnosticOptions` to `RESTORE_SETTABLE` as well? If not,  `CRaCResetStartTime` will be available on checkpoint only as a diagnostic option.


PR Comment: https://git.openjdk.org/crac/pull/135#issuecomment-1786752477

More information about the crac-dev mailing list