[crac] RFR: Persist memory in-JVM [v6]

[Radim Vansa]

On Mon, 25 Sep 2023 17:08:06 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 33 commits:
>> 
>>  - Move MemoryPersister impl to own file
>>  - Merge branch 'crac' into persist_memory
>>  - Backport of API from future changes for other persistent memory features
>>  - Another assembly fix
>>  - Don't fork when we're not unregistering rseq
>>  - Fix assembly loop
>>  - fix whitespaces
>>  - fix whitespaces
>>  - Address review comments, fix rseq on GLIBC < 2.35
>>  - Merge branch 'crac' into persist_memory
>>  - ... and 23 more: https://git.openjdk.org/crac/compare/8fcfc112...1a8fc70c
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 2809:
> 
>> 2807:   // outside CodeCache.
>> 2808:   size_t aligned_size = align_up(stub_size, os::vm_page_size());
>> 2809:   char *stub_memory = os::reserve_memory(aligned_size, true, mtCode);
> 
> Should not this be a global variable as the previous stub?

Only if you want to do something with that pointer in the future, and there were no other references. The memory is allocated once and never released.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/95#discussion_r1340942836