[crac] RFR: Persist memory in-JVM [v6]

[Radim Vansa]

On Mon, 25 Sep 2023 17:25:22 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Radim Vansa has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 33 commits:
>> 
>>  - Move MemoryPersister impl to own file
>>  - Merge branch 'crac' into persist_memory
>>  - Backport of API from future changes for other persistent memory features
>>  - Another assembly fix
>>  - Don't fork when we're not unregistering rseq
>>  - Fix assembly loop
>>  - fix whitespaces
>>  - fix whitespaces
>>  - Address review comments, fix rseq on GLIBC < 2.35
>>  - Merge branch 'crac' into persist_memory
>>  - ... and 23 more: https://git.openjdk.org/crac/compare/8fcfc112...1a8fc70c
>
> src/hotspot/os/linux/crac_linux.cpp line 614:
> 
>> 612:   while (persist_futex) {
>> 613:      syscall(SYS_futex, &persist_futex, FUTEX_WAIT_PRIVATE, 1, nullptr, nullptr, 0);
>> 614:   }
> 
> Nit: in asm it
> 
> do {
>   syscall(SYS_futex, &persist_futex, FUTEX_WAIT_PRIVATE, 1, nullptr, nullptr, 0);
> } while (persist_futex);
> 
> is implemented.

👍  Also I should add the error handling - originally I had it without and that led to busy loops when I've set it incorrectly.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/95#discussion_r1340946729