[crac] RFR: Fix OSX x86_64 CRaC crash [v2]

Radim Vansa rvansa at openjdk.org
Fri Sep 29 16:47:23 UTC 2023


On Fri, 29 Sep 2023 13:15:22 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> - copy-paste the same code from src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp
>> 
>> It has fixed 3 testcases but the last 4th failure looks to be unrelated to this problem.
>> 
>> ==============================
>> Test summary
>> ==============================
>>    TEST                                              TOTAL  PASS  FAIL ERROR
>>    jtreg:test/jdk/jdk/crac/JarFileFactoryCacheTest/JarFileFactoryCacheTest.java
>>                                                          1     1     0     0
>>    jtreg:test/jdk/jdk/crac/MXBean.java                   1     1     0     0
>>    jtreg:test/jdk/jdk/crac/RefQueueTest.java             1     1     0     0
>>    jtreg:test/jdk/jdk/crac/recursiveCheckpoint/Test.java
>>>>                                                       1     0     1     0 <<
>> ==============================
>
> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use nullptr
>    - suggested by Radim Vansa
>    - it follows upstream commit 5d1f71daf06870810c9ca24e911d6191cc4f3006

Marked as reviewed by rvansa (Committer).

-------------

PR Review: https://git.openjdk.org/crac/pull/121#pullrequestreview-1650727481


More information about the crac-dev mailing list