[crac] RFR: Fix OSX x86_64 CRaC crash
Jan Kratochvil
jkratochvil at openjdk.org
Fri Sep 29 16:47:23 UTC 2023
On Fri, 29 Sep 2023 10:12:50 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:
> - copy-paste the same code from src/hotspot/os_cpu/linux_x86/os_linux_x86.cpp
>
> It has fixed 3 testcases but the last 4th failure looks to be unrelated to this problem.
>
> ==============================
> Test summary
> ==============================
> TEST TOTAL PASS FAIL ERROR
> jtreg:test/jdk/jdk/crac/JarFileFactoryCacheTest/JarFileFactoryCacheTest.java
> 1 1 0 0
> jtreg:test/jdk/jdk/crac/MXBean.java 1 1 0 0
> jtreg:test/jdk/jdk/crac/RefQueueTest.java 1 1 0 0
> jtreg:test/jdk/jdk/crac/recursiveCheckpoint/Test.java
>>> 1 0 1 0 <<
> ==============================
You are right. I did not notice as during the x86 commit the code was still using `NULL`s: https://github.com/openjdk/crac/commit/5d1f71daf06870810c9ca24e911d6191cc4f3006
-------------
PR Comment: https://git.openjdk.org/crac/pull/121#issuecomment-1740775076
More information about the crac-dev
mailing list