[crac] RFR: 8355974: [CRaC] Move CPUFeatures verification to the parent process of JVM [v4]
Jan Kratochvil
jkratochvil at openjdk.org
Wed Apr 30 11:19:50 UTC 2025
> There was originally a mistake:
> - restoring JVM did restore the image
> - the restored JVM started checking whether CPU Features of the new host >= CPU Features of the checkpoint host
>
> That is difficult as glibc is already configured (IFUNC) in the image for the checkpoint host and calling any such glibc functions in the restored image will crash (as the advanced instructions from misconfigured IFUNC are not available). Some glibc functions had to be reimplemented in a dummy way inside JVM due to this misdesign.
>
> This patch changes it to:
> - restoring JVM checks `cpufeatures` user data in the image against current CPU Features
> - the restored JVM is started only if the CPU Features are satisfied, restored JVM no longer has to verify anything
>
> The patch is a bit of a kitchen sink, there are various improvements of the CPU Features code.
Jan Kratochvil has updated the pull request incrementally with three additional commits since the last revision:
- Comment the testcase
- Reformat glibc_not_using() caller
- Coding style
-------------
Changes:
- all: https://git.openjdk.org/crac/pull/227/files
- new: https://git.openjdk.org/crac/pull/227/files/03200e67..7e912283
Webrevs:
- full: https://webrevs.openjdk.org/?repo=crac&pr=227&range=03
- incr: https://webrevs.openjdk.org/?repo=crac&pr=227&range=02-03
Stats: 10 lines in 2 files changed: 4 ins; 1 del; 5 mod
Patch: https://git.openjdk.org/crac/pull/227.diff
Fetch: git fetch https://git.openjdk.org/crac.git pull/227/head:pull/227
PR: https://git.openjdk.org/crac/pull/227
More information about the crac-dev
mailing list