[crac] RFR: 8355974: [CRaC] Move CPUFeatures verification to the parent process of JVM [v3]
Jan Kratochvil
jkratochvil at openjdk.org
Wed Apr 30 14:52:53 UTC 2025
On Wed, 30 Apr 2025 08:14:45 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> Jan Kratochvil has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Update required initialization comment
>> - Rename cpufeatures_restore() to cpufeatures_check()
>> - Use log error, not assert
>
> test/jdk/jdk/crac/CPUFeatures/SimpleCPUFeatures.sh line 36:
>
>> 34: unset GLIBC_TUNABLES
>> 35: $JAVA_HOME/bin/java -XX:CPUFeatures=generic -XX:+ShowCPUFeatures -version 2>&1 | tee /proc/self/fd/2 | grep -q 'openjdk version'
>> 36:
>
> Could we add some tests to assert parsing with `glibc.cpu.hwcaps` ?
Oops, you found a bug, thanks. e2b427a28b383f5c2b10b29e92bb1ef2ca4e9882
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/227#discussion_r2068835548
More information about the crac-dev
mailing list