[crac] RFR: 8355974: [CRaC] Move CPUFeatures verification to the parent process of JVM [v3]

[Jan Kratochvil]

On Wed, 30 Apr 2025 07:22:05 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Update required initialization comment
>>  - Rename cpufeatures_restore() to cpufeatures_check()
>>  - Use log error, not assert
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 2658:
> 
>> 2656: 
>> 2657: #ifdef LINUX
>> 2658:   if (!glibc_not_using()) {
> 
> If we are ignoring the result I would just move the comment and not use an empty if

Changed in 35da8647272d9e1ec4376075c2100b4de7e173f0.

> test/jdk/jdk/crac/fileDescriptors/LoggingVMlogOpenTestNegative.java line 79:
> 
>> 77:         } finally {
>> 78:             assertFalse(Files.exists(logPathO));
>> 79:             if (scenario1) {
> 
> The change of behaviour is not clear to me; could you explain this in a comment?

Added comments in: 7e912283a6b30667b5da1b758fe4b257be8af6b5

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/227#discussion_r2068455809
PR Review Comment: https://git.openjdk.org/crac/pull/227#discussion_r2068458833