[crac] RFR: 8365484: [CRaC] Support IgnoreUnrecognizedVMOptions on restore [v2]
Timofei Pushkin
tpushkin at openjdk.org
Thu Aug 21 14:04:43 UTC 2025
On Wed, 20 Aug 2025 13:06:55 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> I see, thanks for the example. Right now, it also has an inconsistency. Suppose you enable it for the restore, and provide nonsense argument. The IgnoreUnrecognizedVMOptions took effect, you can sense unrecognized argument, but you check IgnoreUnrecognizedVMOptions and it's false.
>>
>> I would prefer to remove special handling for the IgnoreUnrecognizedVMOptions, it will make things a bit more straightforward.
>
>> Right now, it also has an inconsistency. Suppose you enable it for the restore, and provide nonsense argument. The IgnoreUnrecognizedVMOptions took effect, you can sense unrecognized argument, but you check IgnoreUnrecognizedVMOptions and it's false.
>
> The unrecognized option will not be forwarded to the restored JVM so there is no inconsistency in this case.
>
> But ok, I'll remove this special handling.
Removed, although I am still not sure what is the best thing to do. Forwarding `IgnoreUnrecognizedVMOptions` seems more consistent, but the ignoring is fully handled by the restoring VM so forwarding it does not make much sense.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/263#discussion_r2291170524
More information about the crac-dev
mailing list