[crac] RFR: 8365484: [CRaC] Support IgnoreUnrecognizedVMOptions on restore [v2]

[Anton Kozlov]

On Thu, 21 Aug 2025 14:01:52 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>>> Right now, it also has an inconsistency. Suppose you enable it for the restore, and provide nonsense argument. The IgnoreUnrecognizedVMOptions took effect, you can sense unrecognized argument, but you check IgnoreUnrecognizedVMOptions and it's false.
>> 
>> The unrecognized option will not be forwarded to the restored JVM so there is no inconsistency in this case.
>> 
>> But ok, I'll remove this special handling.
>
> Removed, although I am still not sure what is the best thing to do. Forwarding `IgnoreUnrecognizedVMOptions` seems more consistent, but the ignoring is fully handled by the restoring VM so forwarding it does not make much sense.

My bad. I mis-interpret the stuff. I see, there is no way "to sense" unrecognized options in the being restored VM. I agree that once all unrecognized are filtered out in restoring VM, there is no reason to forward IgnoreUnrecognizedVMOptions further to the being restored VM. The initial version of the change was good. Could you revert to that? Sorry for this back and forth.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/263#discussion_r2291499730