[crac] RFR: 8365241: [CRaC] Ignore new arguments when CRaCIgnoreRestoreIfUnavailable is true [v4]

Anton Kozlov akozlov at openjdk.org
Thu Aug 21 15:34:11 UTC 2025


On Thu, 21 Aug 2025 15:05:08 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Arguments are not passed to the restored process when `-XX:+CRaCIgnoreRestoreIfUnavailable` is set on restore. The check is performed on the side of the restoring VM since in the restored VM `CRaCIgnoreRestoreIfUnavailable` could have been set before the current restore.
>> 
>> Documentation for the new arguments feature and `CRaCIgnoreRestoreIfUnavailable` is also added, explaining this behavior.
>
> Timofei Pushkin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improve wording in java.md

LGTM with a comment.

test/jdk/jdk/crac/ignoreRestore/RestoreIfPossibleTest.java line 75:

> 73:         if (mainMsgCount != 1) {
> 74:             out.reportDiagnosticSummary();
> 75:             assertEquals(1, mainMsgCount, "Main message should be printed exactly once");

This is effectively `assert(false)`, but written in a more complex way. Let's change this or move it out from the `if`?

-------------

PR Review: https://git.openjdk.org/crac/pull/261#pullrequestreview-3141229260
PR Review Comment: https://git.openjdk.org/crac/pull/261#discussion_r2291426492


More information about the crac-dev mailing list