[crac] RFR: 8365241: [CRaC] Ignore new arguments when CRaCIgnoreRestoreIfUnavailable is true [v4]

Timofei Pushkin tpushkin at openjdk.org
Thu Aug 21 15:38:09 UTC 2025


On Thu, 21 Aug 2025 15:31:03 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Timofei Pushkin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve wording in java.md
>
> test/jdk/jdk/crac/ignoreRestore/RestoreIfPossibleTest.java line 75:
> 
>> 73:         if (mainMsgCount != 1) {
>> 74:             out.reportDiagnosticSummary();
>> 75:             assertEquals(1, mainMsgCount, "Main message should be printed exactly once");
> 
> This is effectively `assert(false)`, but written in a more complex way. Let's change this or move it out from the `if`?

I use assert equals because it prints the expected and the actual values of the counter.

If we move this out of if the diagnostic info will be printed unconditionally (may slow down the test a bit if the output is large for some reason).

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/261#discussion_r2291438042


More information about the crac-dev mailing list