[crac] RFR: 8349365: [CRaC] Handle javaagent adding jars to boostrap/system classpath
Timofei Pushkin
tpushkin at openjdk.org
Thu Feb 6 14:32:31 UTC 2025
On Thu, 6 Feb 2025 09:49:45 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> src/hotspot/share/classfile/classLoader.hpp line 417:
>>
>>> 415:
>>> 416: // returns list of file descriptors used for both boot and app classpath entries
>>> 417: static GrowableArray<int> get_classpath_entry_fds();
>>
>> I am not sure about the name, I assume it's not `get_classpath_append_entry_fds()` because it also includes `_app_classpath_entries` but when CDS is not included neither are the app entries... And as I understand you are not sure we need these app entries for the issue at all (I am also not sure, would need to get a deeper understanding of where do all other checked FDs come from).
>
> That's correct; I wanted to report all FDs 'owned' by `ClassLoader` so that we don't add another method or rename it when we bump into another use-case that's broken.
I mean, currently it does not always report all FDs, only if CDS is included, so the name is somewhat misleading
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/201#discussion_r1944827002
More information about the crac-dev
mailing list