[crac] RFR: 8349560: [CRaC] Close EPoll FDs when FD policies close registered sockets
Radim Vansa
rvansa at openjdk.org
Wed Feb 12 10:12:27 UTC 2025
On Thu, 6 Feb 2025 16:56:53 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
> FD policies are applied as the last set of JDK resources. When these are meant to close server sockets, it’s rather too late: open EPoll FDs won’t be closed automatically as these have the socket still registered when the automatic close is performed.
>
> We can apply FD policies on sockets and close these if requested before EPoll FD handling. The downside is that we would not handle sockets opened during checkpoint, but generally the application should not do that.
>
> Besides changing the order of closing this PR also improves the way EPoll FDs are reported: the Selector throws BusySelectorException listing channels registered on that selector, and EPoll FD and Event Epoll FD are claimed through Java code with message referencing the selector (this suppresses native open FD detection that wouldn't provide much info).
I've tried some rebuilds, sometimes failing on jtreg fetch but now we have a second failure in `PollerTest` on Windows. I don't see why it could be related but I'll need to check it out in depth.
-------------
PR Comment: https://git.openjdk.org/crac/pull/202#issuecomment-2653257994
More information about the crac-dev
mailing list