[crac] RFR: 8349560: [CRaC] Close EPoll FDs when FD policies close registered sockets [v2]
Radim Vansa
rvansa at openjdk.org
Wed Feb 12 17:01:15 UTC 2025
> FD policies are applied as the last set of JDK resources. When these are meant to close server sockets, it’s rather too late: open EPoll FDs won’t be closed automatically as these have the socket still registered when the automatic close is performed.
>
> We can apply FD policies on sockets and close these if requested before EPoll FD handling. The downside is that we would not handle sockets opened during checkpoint, but generally the application should not do that.
>
> Besides changing the order of closing this PR also improves the way EPoll FDs are reported: the Selector throws BusySelectorException listing channels registered on that selector, and EPoll FD and Event Epoll FD are claimed through Java code with message referencing the selector (this suppresses native open FD detection that wouldn't provide much info).
Radim Vansa has updated the pull request incrementally with two additional commits since the last revision:
- Use IOUtil.newFd rather than FileDescriptorAccess
- Change Pollers priority to NORMAL
-------------
Changes:
- all: https://git.openjdk.org/crac/pull/202/files
- new: https://git.openjdk.org/crac/pull/202/files/fb6d4ec6..6aedb6b8
Webrevs:
- full: https://webrevs.openjdk.org/?repo=crac&pr=202&range=01
- incr: https://webrevs.openjdk.org/?repo=crac&pr=202&range=00-01
Stats: 7 lines in 2 files changed: 0 ins; 2 del; 5 mod
Patch: https://git.openjdk.org/crac/pull/202.diff
Fetch: git fetch https://git.openjdk.org/crac.git pull/202/head:pull/202
PR: https://git.openjdk.org/crac/pull/202
More information about the crac-dev
mailing list