[crac] RFR: 8350088: [CRaC] Stop & restart JFR recording on checkpoint [v4]

[Radim Vansa]

On Tue, 18 Feb 2025 09:07:22 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> src/hotspot/share/jfr/jni/jfrUpcalls.cpp line 230:
>> 
>>> 228:     CLEAR_PENDING_EXCEPTION;
>>> 229:     ResourceMark rm(THREAD);
>>> 230:     log_error(jfr, system)("JfrUpcall failed for %s", unhide_internal_types_sym->as_C_string());
>> 
>> Can't we propagate the exception? If not, the method should probably not be marked as `TRAPS` and the `CHECK` above should be transformed to this exception clearing as well?
>
> Also, `unhide_internal_types_sym` should be replaced with `request_start_after_restore_sym`

Thanks for the `unhide_internal_types_sym` catch; copy-paste error. I am not sure if it makes sense to propagate the exception, effectively adding a suppression to the exception called from `Core.checkpointRestore()`. The error would be related to user passing a VM option on restore - not the app code and not affecting correctness of the app when it is restored.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/203#discussion_r1959707749