[crac] RFR: 8350088: [CRaC] Stop & restart JFR recording on checkpoint [v4]

Timofei Pushkin tpushkin at openjdk.org
Tue Feb 18 14:49:27 UTC 2025


On Tue, 18 Feb 2025 13:03:51 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> Also, `unhide_internal_types_sym` should be replaced with `request_start_after_restore_sym`
>
> Thanks for the `unhide_internal_types_sym` catch; copy-paste error. I am not sure if it makes sense to propagate the exception, effectively adding a suppression to the exception called from `Core.checkpointRestore()`. The error would be related to user passing a VM option on restore - not the app code and not affecting correctness of the app when it is restored.

Agree, logging would be enough

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/203#discussion_r1959891289


More information about the crac-dev mailing list