[crac] RFR: 8350088: [CRaC] Stop & restart JFR recording on checkpoint [v4]

[Radim Vansa]

On Tue, 18 Feb 2025 09:04:45 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix module info
>
> src/hotspot/share/jfr/jfr.cpp line 179:
> 
>> 177:     // trying to register new file descriptors. Instead we just record a request and
>> 178:     // the recording will be started at the right moment from JDKResource.
>> 179:     JfrUpcalls::request_start_after_restore(JavaThread::current());
> 
> If `request_start_after_restore` remains trapping (see my other comment in its body), `Jfr::after_restore` should also be marked as such so that the caller would do proper exception handling.

I am not sure what you mean by that - the implementation is not propagating any exception, and there's nothing to be done on the caller side. See `check_internal_types()` for reference.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/203#discussion_r1959716914