[crac] RFR: 8350088: [CRaC] Stop & restart JFR recording on checkpoint [v4]

[Radim Vansa]

On Tue, 18 Feb 2025 14:46:27 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> I am not sure what you mean by that - the implementation is not propagating any exception, and there's nothing to be done on the caller side. See `check_internal_types()` for reference.
>
> Currently `request_start_after_restore` can propagate an exception if its call to `SystemDictionary::resolve_or_fail` fails. But here this propagation will just silently be ignored (and not even cleared).
> 
> Since we've decided that `request_start_after_restore` won't propagate its `call_static` exception I think it should log and clear possible exceptions from `SystemDictionary::resolve_or_fail` and its `TRAPS` mark should be removed.

Nasty `return` hiding under `CHECK`, you are right! Clearing the exceptions after `resolve_or_fail` now.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/203#discussion_r1960580037