[crac] RFR: 8350088: [CRaC] Stop & restart JFR recording on checkpoint [v4]

[Timofei Pushkin]

On Tue, 18 Feb 2025 20:57:06 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> Currently `request_start_after_restore` can propagate an exception if its call to `SystemDictionary::resolve_or_fail` fails. But here this propagation will just silently be ignored (and not even cleared).
>> 
>> Since we've decided that `request_start_after_restore` won't propagate its `call_static` exception I think it should log and clear possible exceptions from `SystemDictionary::resolve_or_fail` and its `TRAPS` mark should be removed.
>
> Nasty `return` hiding under `CHECK`, you are right! Clearing the exceptions after `resolve_or_fail` now.

I would suggest removing `TRAPS` altogether from `JfrUpcalls::request_start_after_restore`. `TRAPS` represents that the method can propagate exceptions and the caller needs to take that into account.

But looks like JFR authors don't see it that way, so up to you.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/203#discussion_r1960587908