[crac] RFR: 8350088: [CRaC] Stop & restart JFR recording on checkpoint [v4]

[Radim Vansa]

On Tue, 18 Feb 2025 21:03:36 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Nasty `return` hiding under `CHECK`, you are right! Clearing the exceptions after `resolve_or_fail` now.
>
> I would suggest removing `TRAPS` altogether from `JfrUpcalls::request_start_after_restore`. `TRAPS` represents that the method can propagate exceptions and the caller needs to take that into account.
> 
> But looks like JFR authors don't see it that way, so up to you.

What you're saying makes sense, though the code is a bit less symmetric. Applied.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/203#discussion_r1960618751