[crac] RFR: 8352675: Support Intel AVX10 converged vector ISA feature detection

[Radim Vansa]

On Mon, 21 Jul 2025 18:19:49 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

> This is the merge of the single commit [3b336a9da091c4df4373d2b845b60d2a7a4e3b1d](https://github.com/openjdk/jdk/commit/3b336a9da091c4df4373d2b845b60d2a7a4e3b1d) which also disables CPUFeatures.

There are significant portions of code commented out through `#if 0` - what are the FIXMEs for?

I like the improved readability with `VM_Version::VM_Features`. Would it be possible to replace the definitions constructed using `VM_STRUCTS_CPU` with a struct, too?

Do you have a test (even some manually-run qemu-based script) that would demonstrate that the changes do what these are supposed to?

src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotJVMCIBackendFactory.java line 99:

> 97:      * @return the set of converted values
> 98:      */
> 99:     static <CPUFeatureType extends Enum<CPUFeatureType>> EnumSet<CPUFeatureType> convertFeatures(

I suppose this is more generic version of the function above; wouldn't it be worth making the above just an adapter to the logic here?

-------------

PR Review: https://git.openjdk.org/crac/pull/247#pullrequestreview-3041458011
PR Review Comment: https://git.openjdk.org/crac/pull/247#discussion_r2221445725