[crac] RFR: 8352675: Support Intel AVX10 converged vector ISA feature detection
Jan Kratochvil
jkratochvil at openjdk.org
Tue Jul 22 07:21:49 UTC 2025
On Tue, 22 Jul 2025 07:13:16 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
> There are significant portions of code commented out through `#if 0` - what are the FIXMEs for?
The CPUFeatures feature has been disabled as it is not ported yet. I will be porting it these days and sure these `#if 0` will be removed then.
Another option would be to remove all the CPUFeatures code but it would be more work to do and then more work to add it back this week.
> I like the improved readability with `VM_Version::VM_Features`. Would it be possible to replace the definitions constructed using `VM_STRUCTS_CPU` with a struct, too?
You mean an upstream refactorization unrelated to CPUFeatures?
> Do you have a test (even some manually-run qemu-based script) that would demonstrate that the changes do what these are supposed to?
CPUFeatures are ignored/disabled now so only normal JVM testsuite matters.
-------------
PR Comment: https://git.openjdk.org/crac/pull/247#issuecomment-3101402531
More information about the crac-dev
mailing list