[crac] RFR: Fix up CPUFeatures on top of Merge jdk:jdk-25+26 [v6]

Timofei Pushkin tpushkin at openjdk.org
Fri Jul 25 17:06:11 UTC 2025


On Fri, 25 Jul 2025 16:58:57 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - buf__features -> buf_features
>>  - Update (*data).print_numbers
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 2567:
> 
>> 2565:     return false;
>> 2566:   }
>> 2567:   VM_Version::VM_Features data = *data_ptr;
> 
> Suggestion:
> 
>   const VM_Version::VM_Features &data = *data_ptr;

Saw your comment regarding copying being faster than referencing for this struct, it is probably the same here, so cresolving

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/250#discussion_r2231624424


More information about the crac-dev mailing list