[crac] RFR: Fix up CPUFeatures on top of Merge jdk:jdk-25+26 [v6]
Jan Kratochvil
jkratochvil at openjdk.org
Fri Jul 25 17:06:11 UTC 2025
On Fri, 25 Jul 2025 17:02:40 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> src/hotspot/cpu/x86/vm_version_x86.cpp line 2567:
>>
>>> 2565: return false;
>>> 2566: }
>>> 2567: VM_Version::VM_Features data = *data_ptr;
>>
>> Suggestion:
>>
>> const VM_Version::VM_Features &data = *data_ptr;
>
> Saw your comment regarding copying being faster than referencing for this struct, it is probably the same here, so cresolving
It is true it may no longer apply in the futuer if VM_Features gets bigger. But yes, I did it based on the referenced benchmark.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/250#discussion_r2231626155
More information about the crac-dev
mailing list