[crac] RFR: 8355974: [CRaC] Move CPUFeatures verification to the parent process of JVM [v11]

Jan Kratochvil jkratochvil at openjdk.org
Fri May 16 11:09:09 UTC 2025


On Tue, 13 May 2025 17:51:57 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with six additional commits since the last revision:
>> 
>>  - Fix LoggingVMlogOpenTestNegative.java failing in Github CI
>>  - Remove S3 support
>>  - Revert "Reimplement S3"
>>    
>>    This reverts commit 719e7568262f87d7367c6656827ece796e35cadb.
>>  - Revert "More S3 fixes but it is untested and for 99.9% not yet working"
>>    
>>    This reverts commit 5ce33434f66913f83b53941b4f9aff8d012f6372.
>>  - More S3 fixes but it is untested and for 99.9% not yet working
>>  - Reimplement S3
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 2645:
> 
>> 2643:     missing_features(features_missing, glibc_features_missing);
>> 2644:     if (!IgnoreCPUFeatures) {
>> 2645:       vm_exit_during_initialization();
> 
> We can just return false here now

True, thanks.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/227#discussion_r2092839530


More information about the crac-dev mailing list