[crac] RFR: 8355974: [CRaC] Move CPUFeatures verification to the parent process of JVM [v11]

[Jan Kratochvil]

On Tue, 13 May 2025 18:28:23 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with six additional commits since the last revision:
>> 
>>  - Fix LoggingVMlogOpenTestNegative.java failing in Github CI
>>  - Remove S3 support
>>  - Revert "Reimplement S3"
>>    
>>    This reverts commit 719e7568262f87d7367c6656827ece796e35cadb.
>>  - Revert "More S3 fixes but it is untested and for 99.9% not yet working"
>>    
>>    This reverts commit 5ce33434f66913f83b53941b4f9aff8d012f6372.
>>  - More S3 fixes but it is untested and for 99.9% not yet working
>>  - Reimplement S3
>
> src/hotspot/share/runtime/crac.cpp line 523:
> 
>> 521:   }
>> 522: 
>> 523:   if (!VM_Version::ignore_cpu_features()) {
> 
> `CPUFeatures` is not restore-settable and `IgnoreCPUFeatures`, rather unexpectedly, does not influence VM_Version::ignore_cpu_features(), so the user will see the warning/errors below even if they knowingly don't want to use CPU features (e.g. their engine doesn't support this).
> 
> But AFAIR we decided to postpone the `CPUFeatures=ignore`/`IgnoreCPUFeatures` cleanup and this can be considered a part of that, so I'm ok with leaving this as is for now.

Yes, ZULU-75248.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/227#discussion_r2092950514