[crac] RFR: 8355974: [CRaC] Move CPUFeatures verification to the parent process of JVM [v16]

Jan Kratochvil jkratochvil at openjdk.org
Mon May 19 09:27:03 UTC 2025


On Mon, 19 May 2025 08:13:19 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Wrap cpufeatures_store() by VM_Version::ignore_cpu_features()
>
> test/jdk/jdk/crac/CPUFeatures/CPUFeatures.sh line 36:
> 
>> 34: qemuimgurl=https://download.fedoraproject.org/pub/fedora/linux/releases/41/Cloud/x86_64/images/Fedora-Cloud-Base-Generic-41-1.4.x86_64.qcow2
>> 35: qemuimgsumurl=https://download.fedoraproject.org/pub/fedora/linux/releases/41/Cloud/x86_64/images/Fedora-Cloud-41-1.4-x86_64-CHECKSUM
>> 36: # FIXME: warp+criu need an update for new kernels:
> 
> OpenJDK only has CRIU, so it was decided not to have any mentions of other engines and their exclusive features in OpenJDK codebase. Could you please remove the mentions here and in other places?

True, fixed in: 876e0926d7144f0ed04e3f8be24bd95a90866a89

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/227#discussion_r2095265800


More information about the crac-dev mailing list